Add OneTimetokenAuthenticator as part of the magic link feature #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajibarra
force-pushed
the
feature/magic-link
branch
14 times, most recently
from
e3a387f to
3d1d4ba
Compare
ajibarra
force-pushed
the
feature/magic-link
branch
from
3d1d4ba to
272ba5e
Compare
steinkel
requested changes
Feb 14, 2025
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| php-version: ['8.1', '8.2'] | ||
| php-version: ['8.2', '8.3', '8.4'] |
There was a problem hiding this comment.
we need to keep 8.1 as cakephp 5 is >=8.1
| @@ -26,18 +26,19 @@ | |||
| "source": "https://github.com/CakeDC/auth" | |||
| }, | |||
| "require": { | |||
| "php": ">=8.1.0", | |||
| "php": ">=8.2.0", | |||
There was a problem hiding this comment.
keep 8.1 for max compatibility with the related cakephp version 5
|
|
||
| $usersTable = TableRegistry::getTableLocator()->get(Configure::read('Users.table')); | ||
|
|
||
| $user = $usersTable->loginWithToken($token); |
There was a problem hiding this comment.
we'll need to define an interface, then check it's implemented by the table, or check the method exists
| @@ -32,7 +32,7 @@ class InvalidProviderException extends CakeException | |||
| * @param int $code code | |||
| * @param null $previous previous | |||
| */ | |||
| public function __construct(array|string $message, int $code = 500, $previous = null) | |||
| public function __construct(array|string $message, int $code = 500, null $previous = null) | |||
| @@ -32,7 +32,7 @@ class InvalidSettingsException extends CakeException | |||
| * @param int $code code | |||
| * @param null $previous previous | |||
| */ | |||
| public function __construct(array|string $message, int $code = 500, $previous = null) | |||
| public function __construct(array|string $message, int $code = 500, null $previous = null) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.